Fixing issue where context modifications in authenticators are ignored#157
Merged
casualjim merged 1 commit intogo-openapi:masterfrom Sep 12, 2019
ApogeeCorp:fix/middleware-context
Merged
Fixing issue where context modifications in authenticators are ignored#157casualjim merged 1 commit intogo-openapi:masterfrom ApogeeCorp:fix/middleware-context
casualjim merged 1 commit intogo-openapi:masterfrom
ApogeeCorp:fix/middleware-context
Conversation
Signed-off-by: Rob Rodriguez <rob@modelrocket.io>
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 80.59% 80.59% +<.01%
==========================================
Files 40 40
Lines 2339 2340 +1
==========================================
+ Hits 1885 1886 +1
Misses 348 348
Partials 106 106
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #157 +/- ##
==========================================
+ Coverage 80.59% 80.59% +<.01%
==========================================
Files 40 40
Lines 2339 2340 +1
==========================================
+ Hits 1885 1886 +1
Misses 348 348
Partials 106 106
Continue to review full report at Codecov.
|
casualjim
approved these changes
Sep 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR address the issue where if the Authenticator adds new http.Request contexts the current it is retained downstream.
Signed-off-by: Rob Rodriguez rob@modelrocket.io