ci(dependencies): automate dependencies updates#289
Merged
Conversation
Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #289 +/- ##
=======================================
Coverage 81.67% 81.67%
=======================================
Files 49 49
Lines 4066 4066
=======================================
Hits 3321 3321
Misses 632 632
Partials 113 113
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5 tasks
fredbi
added a commit
that referenced
this pull request
May 11, 2026
The reinstateSlash logic in resolveURLPath (introduced in 6cdcb95 to fix #289) deliberately excluded pathPattern == "/" to avoid producing "//" when basePath was empty or "/". That left one combination inconsistent with every other trailing-slash case: basePath=/myservice with pathPattern=/ produced /myservice instead of /myservice/. Replace the pattern-shape carve-out with a HasSuffix check on the already-built urlPath, which is idempotent and keeps the double-slash cases unchanged. Closes #101 Signed-off-by: Frédéric BIDON <fredbi@yahoo.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.