Skip to content

fix(auth): detect nil interface vs nil interface#425

Merged
fredbi merged 1 commit intogo-openapi:masterfrom
fredbi:fix/401-concrete-principal
May 4, 2026
Merged

fix(auth): detect nil interface vs nil interface#425
fredbi merged 1 commit intogo-openapi:masterfrom
fredbi:fix/401-concrete-principal

Conversation

@fredbi
Copy link
Copy Markdown
Member

@fredbi fredbi commented May 4, 2026

Change type

Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update

Short description

Fixes

Full description

Checklist

  • I have signed all my commits with my name and email (see DCO. This does not require a PGP-signed commit
  • I have rebased and squashed my work, so only one commit remains
  • I have added tests to cover my changes.
  • I have properly enriched go doc comments in code.
  • I have properly documented any breaking change.

* fixes go-openapi#147

Signed-off-by: Frédéric BIDON <fredbi@yahoo.com>
@codecov
Copy link
Copy Markdown

codecov Bot commented May 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.69%. Comparing base (8b594b4) to head (a6f9d23).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #425   +/-   ##
=======================================
  Coverage   81.69%   81.69%           
=======================================
  Files          50       50           
  Lines        3381     3381           
=======================================
  Hits         2762     2762           
  Misses        507      507           
  Partials      112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fredbi fredbi merged commit dd5f9c7 into go-openapi:master May 4, 2026
21 checks passed
@fredbi fredbi deleted the fix/401-concrete-principal branch May 4, 2026 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When principal is concrete type auth hook can't return nil,nil to get 401

1 participant