Merged
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (50.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 67.22% 67.12% -0.10%
==========================================
Files 30 30
Lines 2407 2412 +5
==========================================
+ Hits 1618 1619 +1
- Misses 621 625 +4
Partials 168 168 ☔ View full report in Codecov by Sentry. |
* documentation update to meet go-openapi standards * fixed discord link * relinted godoc and markdown * relinted the codebase (many nolint directives are set, the design can't be changed easily) * simplified test assertions for JSON & YAML (replaced ad'hoc helpers by testify/v2 features) * test: worked around windows-specific data race issue in tests (used embed fs to avoid windows FS issues) Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
fredbi
force-pushed
the
chore/lint-test-doc
branch
from
369ca8f to
6dee517
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
documentation update to meet go-openapi standards
fixed discord link
relinted godoc and markdown
relinted the codebase (many nolint directives are set, the design can't be changed easily)
simplified test assertions for JSON & YAML (replaced ad'hoc helpers by testify/v2 features)
Change type
Please select: 🆕 New feature or enhancement|🔧 Bug fix'|📃 Documentation update
Short description
Fixes
Full description
Checklist