Skip to content

chore(deps): bump golang.org/x/crypto from 0.48.0 to 0.52.0 in /v2#299

Merged
umputun merged 4 commits into
masterfrom
dependabot/go_modules/v2/golang.org/x/crypto-0.52.0
Jul 10, 2026
Merged

chore(deps): bump golang.org/x/crypto from 0.48.0 to 0.52.0 in /v2#299
umputun merged 4 commits into
masterfrom
dependabot/go_modules/v2/golang.org/x/crypto-0.52.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 10, 2026

Copy link
Copy Markdown
Contributor

Bumps golang.org/x/crypto from 0.48.0 to 0.52.0.

Commits
  • a1c0d99 go.mod: update golang.org/x dependencies
  • 3c7c869 ssh: fix deadlock on unexpected channel responses
  • 533fb3f ssh: fix source-address critical option bypass
  • abbc44d ssh: fix incorrect operator order
  • e052873 ssh: fix infinite loop on large channel writes due to integer overflow
  • b61cf85 ssh: enforce user presence verification for security keys
  • 9c2cd33 ssh: enforce strict limits on DSA key parameters
  • 8907318 ssh: reject RSA keys with excessively large moduli
  • ffd87b4 ssh: fix panic when authority callbacks are nil
  • 4e7a738 ssh: fix deadlock on unexpected global responses
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.48.0 to 0.52.0.
- [Commits](golang/crypto@v0.48.0...v0.52.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.52.0
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Jul 10, 2026
@dependabot
dependabot Bot requested a review from umputun as a code owner July 10, 2026 06:17
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file go Pull requests that update go code labels Jul 10, 2026
@umputun

umputun commented Jul 10, 2026

Copy link
Copy Markdown
Member

CI is red on all four build jobs, and it's the go 1.26 commit rather than the crypto bump. The pin is golangci-lint v2.6.2, whose release binary is built with go1.25, so it panics as soon as setup-go installs 1.26:

panic: file requires newer Go version go1.26 (application built with go1.25)

moving the pin to v2.12.2 (their release workflow builds with GO_VERSION: '1.26') clears the panic, but then gosec opens up. Ran it locally on go1.26.5 with golangci-lint 2.12.2, 32 issues in v2 and 30 in root, almost all from rules that didn't exist in v2.6.2:

  • 17x G124, http.Cookie missing Secure/HttpOnly/SameSite, hits token/jwt.go:280,284,360,364 where we set that deliberately via SecureCookies
  • 5x G101 potential hardcoded credentials on provider/providers.go:174,244,279, those are token endpoint URLs, false positives
  • G706 log injection, G705 XSS, G703 path traversal from the new taint analysis, mostly in tests plus avatar/localfs.go:75 and provider/custom_server.go:196

that's a triage job on its own and doesn't belong in a dependency PR. Can you drop 93b2839 from this branch? 4e00d28 + 402ad9b should go green on the current 1.24 / v2.6.2 setup the way #297 did, and I'd rather have go 1.26, the golangci-lint bump and the gosec fallout in their own PR.

@paskal

paskal commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

Fixing.

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29075784815

Coverage remained the same at 85.5%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3593
Covered Lines: 3072
Line Coverage: 85.5%
Coverage Strength: 8.48 hits per line

💛 - Coveralls

@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 29075784876

Coverage decreased (-0.06%) to 85.445%

Details

  • Coverage decreased (-0.06%) from the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 3559
Covered Lines: 3041
Line Coverage: 85.45%
Coverage Strength: 8.38 hits per line

💛 - Coveralls

@umputun
umputun merged commit 5b77d7f into master Jul 10, 2026
7 of 9 checks passed
@umputun
umputun deleted the dependabot/go_modules/v2/golang.org/x/crypto-0.52.0 branch July 10, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update go code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants