Fix exact IP matching in OnlyFrom - #48
Merged
Merged
Conversation
Parse complete allowlist entries as IP addresses before falling back to textual prefix matching. Cover exact IPv4 and IPv6, CIDR, and explicit prefix behavior.
- [minor] [README.md:107] clarify semantic IP matching rules - [minor] [onlyfrom.go:12] document exact IP, CIDR, and prefix behavior - [major] [onlyfrom.go:46] normalize the in-function comment - [minor] [onlyfrom_test.go:109] cover IPv6 prefix and CIDR behavior - [minor] [onlyfrom_test.go:102] cover matching a later allowlist rule - [major] [onlyfrom_test.go:109] normalize subtest messages
Coverage Report for CI Build 29943272850Coverage increased (+0.02%) to 96.234%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes complete IP rules in
OnlyFromaccepting other addresses with the same text prefix.valid IP rules now use semantic address equality. CIDR and explicit textual prefix rules keep their existing behavior.
adds IPv4 and IPv6 regression coverage, including normalized IPv6 forms and later allowlist rules.