Skip to content

feat: matrix build python-version: ['3.11', '3.12'] #399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
b-long wants to merge 5 commits into
base: master
Choose a base branch
from
+11 −4
Draft

feat: matrix build python-version: ['3.11', '3.12'] #399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
68f5fad
feat: matrix build `python-version: ['3.11', '3.12']`
b-long Jul 24, 2026
1273f46
bind: make _gopy_clear_go_tls opt-in, off by default
Jul 23, 2026
d41db33
fix complex conversion crash on CPython 3.12
b-long Jul 24, 2026
b46aa9e
Revert "bind: make _gopy_clear_go_tls opt-in, off by default"
b-long Jul 24, 2026
202b0fb
Merge branch 'master' into feature/pr-398-regression-test
b-long Jul 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,14 @@ env:
jobs:

build:
name: Build
name: Build (${{ matrix.platform }}, Go ${{ matrix.go-version }}, Python ${{ matrix.python-version }})
strategy:
fail-fast: false
matrix:
# TODO: Consider official support matrix (OS and Go versions) and adjust this matrix accordingly
go-version: [1.25.x, 1.24.x, 1.23.x, 1.22.x]
platform: [ubuntu-latest, windows-latest, macos-15]
python-version: ['3.11', '3.12']
runs-on: ${{ matrix.platform }}
steps:
- name: Checkout code
Expand All @@ -33,7 +34,7 @@ jobs:
- name: Set up Python
uses: actions/setup-python@v5
with:
python-version: '3.11'
python-version: ${{ matrix.python-version }}

- name: Install Go
uses: actions/setup-go@v5
Expand Down
10 changes: 8 additions & 2 deletions bind/gen.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,10 @@ func boolPyToGo(b C.char) bool {
}

func complex64GoToPy(c complex64) *C.PyObject {
return C.PyComplex_FromDoubles(C.double(real(c)), C.double(imag(c)))
gstate := C.PyGILState_Ensure()
obj := C.PyComplex_FromDoubles(C.double(real(c)), C.double(imag(c)))
C.PyGILState_Release(gstate)
return obj
}

func complex64PyToGo(o *C.PyObject) complex64 {
Expand All @@ -203,7 +206,10 @@ func complex64PyToGo(o *C.PyObject) complex64 {
}

func complex128GoToPy(c complex128) *C.PyObject {
return C.PyComplex_FromDoubles(C.double(real(c)), C.double(imag(c)))
gstate := C.PyGILState_Ensure()
obj := C.PyComplex_FromDoubles(C.double(real(c)), C.double(imag(c)))
C.PyGILState_Release(gstate)
return obj
}

func complex128PyToGo(o *C.PyObject) complex128 {
Expand Down
Loading