Merged
Conversation
hajimehoshi
reviewed
Mar 27, 2026
| // Format 1: small metrics, byte-aligned data | ||
| // Format 2: small metrics, bit-aligned data | ||
| type BitmapData2 struct { | ||
| type BitmapData1or2 struct { |
Contributor
There was a problem hiding this comment.
BitmapData1Or2 sounds slighly better (to me)
Contributor
Author
There was a problem hiding this comment.
Done, thank you.
whereswaldon
approved these changes
Mar 27, 2026
Member
whereswaldon
left a comment
whereswaldon
left a comment
There was a problem hiding this comment.
Thanks for addressing this so quickly!
Contributor
Author
|
Waiting for @andydotxyz approval since there is an API change. |
andydotxyz
approved these changes
Mar 28, 2026
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for bitmap black and white glyphs with Format1.
Since the rendering logic should be slightly different than other black and white format already supported, I have added a new format
BlackAndWhiteByteAligned.Closes #244