feat: add DeleteUser to storage interface and backends - #17
Conversation
|
Good work on covering both backends and the README! One thing is missing though: Could you add it? func (s *InMemoryStorage) DeleteUser(id string) error {
s.mu.Lock()
defer s.mu.Unlock()
for username, user := range s.users {
if user.ID == id {
delete(s.users, username)
return nil
}
}
return nil
}The reason the build passed locally is that nothing in this branch directly assigns |
|
Thanks for catching that. I added \DeleteUser\ to \internal/storage/memory/memory.go\ and included a memory backend regression test with a compile-time \storage.Storage\ assertion in \internal/storage/memory/memory_test.go\. I also ran \git diff --check\ locally. I couldn't run \go test ./...\ in this Codex environment because the Go toolchain isn't installed on PATH here. |
|
Thanks! |
Summary
Closes #12