chore(ci): gofmt gate, and the drift it would have caught - #14
Merged
Conversation
go vet does not check formatting, so drift accumulates silently: ten files had gone out of gofmt on main — six in internal/wayland, two in internal/cocoa, internal/x11/shm.go and wlwindow_test.go. Adding the gate without reformatting would simply have made main red, so both are here. The step prints the diff, not just the file names, so a failure says what to change rather than only where. Formatting only; no behaviour is touched. Builds and the full test suite are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go vetdoes not check formatting, so drift accumulates silently. Ten fileshad gone out of gofmt on
main:internal/wayland/—conn.go,xkb.go,present_test.go,seat_test.go,surface_test.go,xkb_test.gointernal/cocoa/—mapping_test.go,live_darwin_test.gointernal/x11/shm.gowlwindow_test.goAdding the gate without reformatting would simply have made
mainred, so bothare in this change.
The step prints the diff, not just the file names, so a failure says what to
change rather than only where:
Formatting only — no behaviour is touched. Builds and the full test suite are
unchanged.
Found while porting the accessibility bridges into this repo; kept as its own
change rather than folded into that work.
🤖 Generated with Claude Code