Add pull_request trigger to CI workflow - #137
Merged
Merged
Conversation
Required to support requiring the build check in branch protection - a push-only trigger never runs against a fork PR's head commit, which would block external contributions once the check is required. The existing build job already needs the full test matrix, so it can serve as the single required check without a separate aggregator job.
Gives branch protection a single, stable check name to require, independent of what jobs the workflow happens to run - so adding a matrix build or a lint job later only means updating this job's needs list, not the required checks in Terraform.
jcardozagc
approved these changes
Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pull_requesttrigger alongside the existingpushtrigger sobuildruns against fork PRs, not just pushes to the repo.pushtrigger tomasteronly (post-merge publish flow is unaffected - it already gates ongithub.ref == 'refs/heads/master').Why
Part of IX-2323: setting up required status checks across GoCardless's public client library repos so we can safely enable auto-merge. A push-only trigger never runs against a fork PR's head commit, so requiring
buildin branch protection would otherwise block every external contribution. The existingbuildjob alreadyneeds: [test]on the full test matrix, so it can serve as the single required check without a separate aggregator job.Test plan
buildappears and passes on this PR