fix(api-catalog): resync spec drift and test the whole workspace in CI

[jpage-godaddy]

Summary

• Regenerates the embedded API catalog / domains-client codegen spec / hosting-nodejs spec via cargo run -p generate-api-catalog, resolving the drift flagged by API catalog drift #33455833918: domains v3 gained a getRegistrationSchema endpoint, and hosting-nodejs v1 added deprecation notices on rollbackApp and updateAppSecrets.
• Fixes cicd.yml and rust-port-alpha.yaml to run cargo check/clippy/test with --workspace. This workspace has a root package (godaddy-cli) plus domains-client and generate-api-catalog as members with no default-members override, so plain cargo test has only ever covered the root package — domains-client's own test module has never actually compiled or run in CI, on PRs or otherwise.
• Fixes the five compile errors and one runtime bug that gap was hiding in domains-client/src/lib.rs's tests (all pre-existing on main, unrelated to the spec resync above — verified against unmodified main before touching anything): optimize_for became Option-wrapped, ConsentActorType/AgreementType moved from generated enums to open string newtypes, DnsRecord gained a required parameters field, Agreements's privacy setter was renamed to v1_privacy, and a mock asserted the wrong wire query-param name (privacy instead of the API's actual v1-privacy, confirmed directly against the live upstream spec).
• Updates AGENTS.md's documented commands/checklist to match (--workspace everywhere).

Test plan

• cargo check --workspace
• cargo clippy --workspace --all-targets -- -D warnings
• cargo fmt --check
• cargo test --workspace (752 + 15 + 15 passed across all three crates)
• ./rust/scripts/check-module-size.sh
• No unresolved external $refs in the regenerated catalog (CICD's own check)
• Forced a rebuild of domains-client to confirm progenitor codegen compiles against the new getRegistrationSchema operation

🤖 Generated with Claude Code

[Copilot]

Pull request overview

Resynchronizes the embedded API catalog and domains-client OpenAPI inputs with upstream spec drift, and updates CI/agent guidance to run Rust checks across the entire workspace (so domains-client and generate-api-catalog are covered in PR CI).

Changes:

• Regenerated API catalog artifacts to reflect new/updated endpoints and descriptions (domains v3 getRegistrationSchema; hosting-nodejs v1 deprecation/supersession notes).
• Fixed CI workflows to run cargo check/clippy/test with --workspace under rust/.
• Updated domains-client tests to match regenerated types/params (Option-wrapped fields, open-string newtypes, required fields, and corrected v1-privacy query param + setter rename).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
rust/schemas/openapi/hosting-nodejs-public-v1.yaml	Adds v1 operation descriptions (and deprecation marker) aligned with upstream hosting-nodejs spec.
rust/schemas/api/manifest.json	Updates generation timestamp and increments domains endpoint count to reflect the new endpoint.
rust/schemas/api/hosting-nodejs.json	Regenerated catalog entry text for rollbackApp and updateAppSecrets descriptions.
rust/schemas/api/domains.json	Adds RegistrationSchema schema and the getRegistrationSchema endpoint entry.
rust/domains-client/src/lib.rs	Fixes/updates the crate’s test module to compile/run under the regenerated types and correct query param naming.
rust/domains-client/openapi/domains.oas3.json	Updates the domains-client OpenAPI input with the new registration schema endpoint and component schema.
AGENTS.md	Updates documented Rust commands/checklist to consistently use --workspace.
.github/workflows/rust-port-alpha.yaml	Runs clippy/tests against the entire Rust workspace.
.github/workflows/cicd.yml	Runs check/clippy/tests against the entire Rust workspace to ensure all member crates are covered.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.