Deprecate #[class(no_init)] for editor plugins
#1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Godot editor requires default-constructible plugins. Using `no_init` will cause an error when opened in the editor.
Concerns: - #[class(editor_plugin)] - #[class(hidden)] - #[init(default = ...)] Those already caused compile errors, since the deprecation functions no longer existed, so this is not a breaking change. However, the new approach produces more readable errors.
Bromeon
added
bug
c: register
|
API docs are being generated and will be shortly available at: https://godot-rust.github.io/docs/gdext/pr-1378 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Outlawed
no_initfor editor pluginsThe Godot editor requires default-constructible plugins. Using
no_initwill cause an error and may even crash the editor:After this change, this emits a warning. Deprecated due to SemVer, will become a hard error in v0.5.
Better errors for removed proc-macro APIs
This also turns some already removed proc-macro APIs into readable errors:
#[class(editor_plugin)]#[class(hidden)]#[init(default = ...)]Before -- those were deprecated, but the referenced symbols were already removed, resulting in compile errors:
After:
