Skip to content

javascript: Cleanup and source env in ~/.bashrc #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2019
Merged

javascript: Cleanup and source env in ~/.bashrc #2

merged 1 commit into from
Oct 10, 2019

Conversation

@akien-mga
Copy link
Member

@akien-mga akien-mga commented Aug 31, 2019

This way we shouldn't need to source emsdk_env.sh manually when building templates.

@akien-mga akien-mga added the enhancement New feature or request label Aug 31, 2019
@akien-mga akien-mga requested a review from hpvb August 31, 2019 10:46
@akien-mga
Copy link
Member Author

akien-mga commented Sep 30, 2019

This one should be OK to merge @hpvb.

@hpvb hpvb merged commit 6cc9151 into godotengine:master Oct 10, 2019
@hpvb
Copy link
Member

hpvb commented Oct 10, 2019

Thanks!

@akien-mga akien-mga deleted the javascript-source-env branch December 22, 2019 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hpvb hpvb Awaiting requested review from hpvb

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@akien-mga @hpvb