Update example.gdextension to reflect the actual paths of the framework files. #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
approved these changes
Sep 17, 2024
Contributor
dsnopek
left a comment
dsnopek
left a comment
There was a problem hiding this comment.
I agree that this would be a nice change! This is something I always need to remember to update when making MRPs.
It would also be nice if it used libEXTENSION-NAME rather than libgdexample to match what's in the SConstruct file by default. But we could do that in another PR, because that's likely a more controversial change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: Superseded by #49.
The example doesn't work out of the box, due to sub-paths, at least for me.
Bugsquad edit: Fixes #50