[DRAFT] Optimize Object::cast_to<T>() using Object::is_class() now that it takes a StringName#1974
Draft
dsnopek wants to merge 2 commits intogodotengine:masterfrom
Draft
[DRAFT] Optimize Object::cast_to<T>() using Object::is_class() now that it takes a StringName#1974dsnopek wants to merge 2 commits intogodotengine:masterfrom
Object::cast_to<T>() using Object::is_class() now that it takes a StringName#1974dsnopek wants to merge 2 commits intogodotengine:masterfrom
Conversation
…t takes a `StringName`
dsnopek
added
the
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After godotengine/godot#118582, in Godot 4.7,
Object::is_class()now takes aStringNamewhich allows us to write a much simpler and faster version ofObject::cast_to<T>()that doesn't usedynamic_cast<T>()I've also chosen to simplify the code for Godot 4.6 and earlier to only do the
dynamic_cast<T>(). Since we have to do that in the end anyway, we may as well skip all the other junk. This is theoretically slower if the object can't be cast to the requested type, but faster if it can, so I expect it to be a washThis is marked as a DRAFT because it depends on #1972