Skip to content

[SCons] Platform agnostic default toolchain (GNU). #971

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2022
Merged

[SCons] Platform agnostic default toolchain (GNU). #971

merged 1 commit into from
Dec 20, 2022

Conversation

@Faless
Copy link
Contributor

@Faless Faless commented Dec 20, 2022

Create the SCons Environment with an empty PLATFORM variable to force the default tools to use the GNU toolchain.

Platform specific toolchains are then setup in our custom tools.

Fixes #937

@Faless Faless added enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup labels Dec 20, 2022
@Faless Faless added this to the 4.0 milestone Dec 20, 2022
@Faless Faless requested a review from a team as a code owner December 20, 2022 14:28
@Faless Faless force-pushed the build/4.x_default_gnu branch from c6211b4 to 6349d40 Compare December 20, 2022 16:34
@Faless
[SCons] Platform agnostic default toolchain (GNU).
8d6982b 
Create the SCons Environment with an empty PLATFORM variable to force
the default tools to use the GNU toolchain.

Platform specific toolchains are then setup in our custom tools.
@Faless Faless force-pushed the build/4.x_default_gnu branch from 6349d40 to 8d6982b Compare December 20, 2022 16:41
@DmitriySalnikov
Copy link
Contributor

DmitriySalnikov commented Dec 20, 2022

With this fix, it finally became possible to build a library on Windows.
Thanks!

C:\Android\SDK\ndk\23.2.8568313/toolchains/llvm/prebuilt/windows-x86_64/bin/clang++ -o gen\src\variant\utility_functions.android.template_release.arm64.o -c -std=c++17 --target=aarch64-linux-android21 -march=armv8-a -fPIC -O3 -Igdextension -Iinclude -Igen\include gen\src\variant\utility_functions.cpp
scons: `bin\libgodot-cpp.android.template_release.arm64.a' is up to date.
scons: done building targets.

@akien-mga akien-mga merged commit 99de0a8 into godotengine:master Dec 20, 2022
@akien-mga
Copy link
Member

akien-mga commented Dec 20, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees

No one assigned

Labels

enhancement This is an enhancement on the current functionality topic:buildsystem Related to the buildsystem or CI setup

Projects

None yet

Milestone

4.0

Development

Successfully merging this pull request may close these issues.

Can't compile library for Android using Windows

4 participants

@Faless @DmitriySalnikov @akien-mga @qdeanc