Offline stable docs

[CitrusWire]

This page: https://github.com/godotengine/godot-docs says:
"To browse the documentation offline, you can download an HTML copy for offline reading (updated every Monday)."

It doesn't explicitly say it's unstable, though I guess this is implied by the "updated every Monday". Surely a better option for this page is a link to download the stable docs as that's what most people will want?

2nd:

When I load these docs, I get:

except the link to the "stable" docs points to the page I'm already looking at: localhost/godot_docs/tutorials/2d/index.html.
So every page in the docs starts by wasting the premium vertical real-estate with a meaningless warning.

[AThousandShips]

You can find all the different branches of offline documentation on the main page in the latest branch, see here, this needs to be updated on the main read-me as well

[CitrusWire]

Thanks. Yeah, those are the links I was looking for. I'd suggest they should be there rather than the current docs one, or at least there should be clear links to both sets.

[AThousandShips]

The stable docs page hasn't been updated yet so that's just something that'll be updated when the cherry-picks are rolled over, the rest is just a simple change to the main readme

[Calinou]

Regarding the unstable version notice, the reason why this notice is here is because of this:

godot-docs/_templates/layout.html

Lines 33 to 45 in 6e6b257

	{% if godot_is_latest %}
	<div class="admonition attention latest-notice">
	<p class="first admonition-title">Attention: Here be dragons</p>
	<p>
	This is the <code class="docutils literal notranslate"><span class="pre">latest</span></code>
	(unstable) version of this documentation, which may document features
	not available in or compatible with released stable versions of Godot.
	</p>
	<p class="last latest-notice-link">
	Checking the stable version of the documentation...
	</p>
	</div>
	{% endif %}

However, godot_is_latest is correctly set to False in conf.py in the stable branch, so it doesn't appear there.

When building the master branch on CI, godot_is_latest is explicitly set to False before building to hide the warning box:

godot-docs/.github/workflows/build_offline_docs.yml

Lines 47 to 49 in 222a545

	# Remove banners at the top of each page when building `latest`.
	sed -i 's/"godot_is_latest": True/"godot_is_latest": False/' conf.py

This used to work, but it doesn't work anymore (even though this sed command works correctly locally). I have no idea why this is happening.