-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Standardize RST header syntax #10370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize RST header syntax #10370
Conversation
| ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the one "real" change here, and the source of the +1 line. It adds a space between the header and a table.
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to find time to review all of this but I'm ok with this standardization. @mhilbrunner any thoughts?
|
Note that even though there are no conflicts, this is no longer good to merge as-is without going through all the pages again, due to additions within the changed pages that still use the existing set of header syntax. |
|
@tetrapod00 I think this looks good and makes sense, feel free to rebase/fix and then go ahead and merge to avoid conflicts piling up again. |
331aa5a to
db5ecf6
Compare
db5ecf6 to
c4d3aa1
Compare
|
I looked through the already changed pages and found two fixes to make. Additionally, I looked through recently merged new pages and updated those as well. Since I don't expect us to merge any more large pages during this slow period, I'll wait to merge this for just a little while in case @skyace65 or anyone else wants to take another look. |
|
Lets start the new year by getting this in :) Thanks! |
See #10369. Discuss and approve that PR first. As is, this PR implements the standard order of headers described in that PR:
I think I found all the changes to make here, but I might have missed some pages. Since RST handles header syntax per-page, it's not a big deal to come back later and fix any pages that I mised. In each changed page here, I made sure to read through the whole page and confirm that the required changes have been made.