Sync "Creating the Enemy" section of Getting Started/First Game 2D tutorial with demo project code #10513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateuseap
force-pushed
the
fix/creating-the-enemy
branch
from
7c7525e to
72962a8
Compare
skyace65
added
enhancement
area:getting started
skyace65
requested changes
Jan 25, 2025
| .. code-tab:: gdscript GDScript | ||
|
|
||
| func _on_visible_on_screen_notifier_2d_screen_exited(): | ||
| func _on_VisibilityNotifier2D_screen_exited(): |
Contributor
There was a problem hiding this comment.
This isn't really a comment on your PR, more a note for myself that I need to check why we're using a non automatically generated function name before this is merged.
mateuseap
force-pushed
the
fix/creating-the-enemy
branch
3 times, most recently
from
1288119 to
af2f8c8
Compare
Updated a GDScript code snippet and an explanation in the "Creating the Enemy" section of the Getting Started/First Game 2D tutorial to ensure consistency with the "Dodge the Creeps" demo project. Update code in "Creating the Enemy" section of First 2D Game tutorial.
mateuseap
force-pushed
the
fix/creating-the-enemy
branch
from
af2f8c8 to
51f6a1b
Compare
Contributor
Author
|
@skyace65 the GDScript and C# versions are now up to date with the "Dodge the Creeps" demo project. No changes were needed for the C# code — only the GDScript required updates. I've also properly adapted the explanation to cover both implementations. |
skyace65
requested changes
Feb 2, 2025
skyace65
approved these changes
Feb 2, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10508
Changes made
getting_started/first_2d_game/04.creating_the_enemy.rstto match the "Dodge the Creeps" demo project, specifically aligning it with dodge_the_creeps/mob.gd. Additionally, I refined the explanation related to this code, considering both the GDScript and C# implementations.Note: The C# code was already in sync with dodge_the_creeps/mob.gd, so no changes were made to it.