-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix: validate with is_network_master is correct form. #3790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I believe this is incorrect. |
the method has_method doesn't work in this scope, when the game instance isn't master it's returning true too. |
it's possible or sense add this methods: is_master_method() and is_puppet_method() |
|
It is probably a good change. The actual demo contains this: But the tutorial leaves the first three lines of explode implicit (which this pull-request is adding in, albeit in a different place). This does not change the often-raised issue of authoritativeness, which might still exist (but should probably be addressed separately). |
|
perhaps it's just a matter of ANDing the two conditions? if (p.is_network_master() && p.has_method("exploded")) {
// Do the thing...
} |
|
Is this still relevant with the latest documentation as of 4.1? |
|
The Page was updated by #7675 and cherry picked to all 4.x branches. Closing as the change is no longer relevant. |
has_method returns true even if node isn't the master
is_network_master returns correct validation.