Skip to content

Conversation

@jomiq
Copy link

@jomiq jomiq commented Dec 1, 2022

Small change.
Resolves #6443

@YuriSizov
Copy link
Contributor

These samples need to be rewritten, because there is no point constructing Callables like that. Each function is already a Callable, it can be simply referenced.

@jomiq
Copy link
Author

jomiq commented Dec 1, 2022

OK,
I just saw #2592. Should I close #6443 and reference that instead?

@YuriSizov
Copy link
Contributor

I don't think that the issue that you've linked has any relevance here, it's from 2019. Callable is a new concept for Godot 4, and it's not just a rename of funcref. Each method of a class is already a Callable, so the examples can use them directly, instead of creating funcrefs. This still needs to be changed, just not the way that you've done it. You can still improve this PR and correct the code samples.

@Calinou Calinou added the bug label Dec 1, 2022
@skyace65 skyace65 added the area:manual Issues and PRs related to the Manual/Tutorials section of the documentation label Jan 13, 2023
@mhilbrunner
Copy link
Member

Fixed in #6542. Thanks for contributing!

@mhilbrunner mhilbrunner added archived and removed bug area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

funcref renamed to Callable

5 participants