Add note about removing new_game() _ready() in 2D tut #6781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Start button handles calling `new_game()` so without removing the `_ready()` function that called `new_game()`, the game will automatically start on launch.
Contributor
|
Note that this line already exists in the "Testing the scene" section:
|
Contributor
Author
|
@cbscribe Thanks, I see that now! Whoops. I missed it when going through the tutorial. Should I just close this out then? |
Contributor
|
I think it's ok to have the reminder at the point you added it. Although I'd suggest changing the wording a little to indicate it's a reminder in case you missed doing it earlier. |
Based on feedback from cbscribe since it's mentioned in the previous part of the tutorial.
Contributor
|
lgtm |
Calinou
added
enhancement
area:getting started
mhilbrunner
approved these changes
Feb 23, 2023
Member
|
Thank you! Merged. Thanks for contributing! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Start button handles calling
new_game()so without removing the_ready()function that callednew_game(), the game will automatically start on launch.I've been going through: https://docs.godotengine.org/en/latest/getting_started/first_2d_game/06.heads_up_display.html and noticed this little issue.
Happy to adjust the language in any way that I can to make it better. Let me know if I'm missing anything!