-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Update Tween cheatsheet to add TRANS_SPRING #7464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for contributing! Please convert the PNG file to WebP while you're at it (we're in the process of moving the docs repository over to WebP, see image creation guidelines). |
|
Oh sry I forgot |
080eb2b to
b504a0e
Compare
|
I need to change the .png to .webp on the tween class reference right? |
|
Yes, in the Tween.xml file. |
|
Copying here for ease of review: Maybe the legend could be moved to the right side (or top or bottom, worth testing) to keep the actual tween graphs aligned on a 4x3 grid? While at it, the legend could be adjusted as currently the squares and the captions aren't aligned. Note to maintainers: This shouldn't be cherry-picked to 4.0, |
Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
b504a0e to
8bb1398
Compare
|
So I pushed an update to do what I suggested: But then I checked the original and I see there's more changes than just adding the new transition. The transition names are now much smaller and hard to read, and the title was lost. The out of alignment legend was also a bug introduced in this PR. I think the transition names in the original were a bit too big and overlapping with the graphs, but now they're too small and lack contrast. How did you edit / recreate the file? Might be better to go back to the original sources from @aaronfranke to do it properly. BTW if this were to be redone from source, I would suggest ordering the transitions like in the enum. The current order seems completely arbitrary. |
…odot-docs into update_tween_cheatsheet
|
Looks great! The new file as webp is a bit big (300+ kB), we might want to look at using a more aggressive lossless compression factor, or a slightly lossy compression. |
|
Lossless optimization with I think 300+ KB is fine though, that's not really all that big. If it was several MB then maybe it would be too big. |
|
Thanks! |
|
@br1trs Do you still have the source project files used to generate the image? I've tried wandomPewlin/godotTweeningCheatSheet#1 which works in 4.4.1, but it looks different from your image. It's also very slow to draw (it takes several seconds for each line to appear), and the proportions look incorrect: |
|
Hey @Calinou! Just saw your message, sorry about that, lol. I no longer had the project, but I made a new project that recreates what I did last time. It generates the image way more efficiently and precisely for the wiki page, and it lives in the draw() function so you can tweak it in real-time. I'm sharing the zip file containing the source project files for Godot 4.1.1. Let me know if you have any issues. |







fixes #7405
updated tween cheatsheet to include TRANS_SPRING