Skip to content

Conversation

@br1trs
Copy link
Contributor

@br1trs br1trs commented Jun 4, 2023

fixes #7405

updated tween cheatsheet to include TRANS_SPRING

@mhilbrunner
Copy link
Member

Thanks for contributing!

Please convert the PNG file to WebP while you're at it (we're in the process of moving the docs repository over to WebP, see image creation guidelines).

@mhilbrunner mhilbrunner added area:manual Issues and PRs related to the Manual/Tutorials section of the documentation content:images Issues and PRs involving outdated or incorrect images in articles cherrypick:4.0 labels Jun 4, 2023
@mhilbrunner mhilbrunner added this to the 4.1 milestone Jun 4, 2023
@mhilbrunner mhilbrunner added the bug label Jun 4, 2023
@br1trs
Copy link
Contributor Author

br1trs commented Jun 5, 2023

Oh sry I forgot

@br1trs br1trs force-pushed the update_tween_cheatsheet branch from 080eb2b to b504a0e Compare June 6, 2023 05:32
@br1trs
Copy link
Contributor Author

br1trs commented Jun 6, 2023

I need to change the .png to .webp on the tween class reference right?

@Piralein
Copy link
Member

Piralein commented Jun 6, 2023

Yes, in the Tween.xml file.
This requires a second PR inside the main repository with this PR linked.

@akien-mga akien-mga changed the title Update tween_cheatsheet.png Update Tween cheatsheet to add TRANS_SPRING Jun 8, 2023
@akien-mga
Copy link
Member

akien-mga commented Jun 8, 2023

Copying here for ease of review:

image

Maybe the legend could be moved to the right side (or top or bottom, worth testing) to keep the actual tween graphs aligned on a 4x3 grid?

While at it, the legend could be adjusted as currently the squares and the captions aren't aligned.


Note to maintainers: This shouldn't be cherry-picked to 4.0, TRANS_SPRING is a new feature in 4.1.

Co-authored-by: Rémi Verschelde <rverschelde@gmail.com>
@akien-mga akien-mga force-pushed the update_tween_cheatsheet branch from b504a0e to 8bb1398 Compare June 12, 2023 08:03
@akien-mga
Copy link
Member

akien-mga commented Jun 12, 2023

So I pushed an update to do what I suggested:

image

But then I checked the original and I see there's more changes than just adding the new transition. The transition names are now much smaller and hard to read, and the title was lost. The out of alignment legend was also a bug introduced in this PR. I think the transition names in the original were a bit too big and overlapping with the graphs, but now they're too small and lack contrast.

image

How did you edit / recreate the file? Might be better to go back to the original sources from @aaronfranke to do it properly.

BTW if this were to be redone from source, I would suggest ordering the transitions like in the enum. The current order seems completely arbitrary.

@aaronfranke
Copy link
Member

aaronfranke commented Jun 12, 2023

I didn't make this source file. @Calinou did here #3403

@br1trs
Copy link
Contributor Author

br1trs commented Jun 13, 2023

hi! so after checking the comments made by Akien, I have made some adjustments to the cheatsheet, it now follows the same order as the enum, and I added more space to make it more readable. Let me know what you think.
245073325-b69d7002-c38a-477a-9392-c09079474e65

@akien-mga
Copy link
Member

Looks great! The new file as webp is a bit big (300+ kB), we might want to look at using a more aggressive lossless compression factor, or a slightly lossy compression.

@aaronfranke
Copy link
Member

Lossless optimization with cwebp -z 9 only brings the file size down by under 1% (322 KB -> 319 KB).

tween_cheatsheet.webp.zip

I think 300+ KB is fine though, that's not really all that big. If it was several MB then maybe it would be too big.

@akien-mga akien-mga merged commit c9a72d0 into godotengine:master Jun 15, 2023
@akien-mga
Copy link
Member

Thanks!

@Calinou
Copy link
Member

Calinou commented Jun 15, 2023

The image compresses poorly because it's a lossy source compressed to a lossless image 🙂

image

You'd need to recreate the entire image from scratch and ensure it's only ever saved with lossless compression.

@Calinou
Copy link
Member

Calinou commented Jun 25, 2025

@br1trs Do you still have the source project files used to generate the image? I've tried wandomPewlin/godotTweeningCheatSheet#1 which works in 4.4.1, but it looks different from your image.

It's also very slow to draw (it takes several seconds for each line to appear), and the proportions look incorrect:

image

@br1trs
Copy link
Contributor Author

br1trs commented Jul 13, 2025

Hey @Calinou! Just saw your message, sorry about that, lol. I no longer had the project, but I made a new project that recreates what I did last time. It generates the image way more efficiently and precisely for the wiki page, and it lives in the draw() function so you can tweak it in real-time. I'm sharing the zip file containing the source project files for Godot 4.1.1. Let me know if you have any issues.
image
CheatSheet.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation bug content:images Issues and PRs involving outdated or incorrect images in articles

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tween cheat sheet needs updating

6 participants