Fix OBJECT_POSITION description to match engine behavior. #7560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
approved these changes
Jun 26, 2023
Piralein
added
enhancement
area:manual
mhilbrunner
approved these changes
Jul 18, 2023
Member
|
Thanks for taking the time to contribute and fix this for all Godot users! Merged. 🎉 |
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While doing some custom SDF work in a fog shader, I noticed the documentation for
OBJECT_POSITIONdid not match engine behavior.You can see an example in the engine's fog shader where they need both
WORLD_POSITIONandOBJECT_POSITIONto get a position in local space here: https://github.com/godotengine/godot/blob/3710f069293f2fde8afe33fea898c4b36fa5e943/scene/resources/fog_material.cpp#L160