Skip to content

Conversation

@dsnopek
Copy link
Contributor

@dsnopek dsnopek commented Jun 26, 2023

This PR is attempting to specifically address the points of confusion from godotengine/godot#78427

Namely:

  • Making it extra clear that you need to follow most of the normal Android setup steps before doing the things on the OpenXR-specific page.
  • Changing one of the screenshots to have the "Use Gradle build" checkbox checked (as described in the text instructions, but confusingly shown unchecked in the original screenshot)
  • Specifically linking to the "One-click deploy" documentation, and making it clear that developers may need to perform some extra steps from their headset vendor's documentation in order to make it work. And I added a note and link for the Meta Quest in particular, since it's the most popular headset.

I also fixed some terminology that I think is incorrect: "export template" -> "export preset"

@dsnopek dsnopek added the topic:xr Related to XR documentation label Jun 26, 2023
@dsnopek dsnopek requested review from BastiaanOlij and Calinou June 26, 2023 18:44
@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jun 27, 2023
@BastiaanOlij
Copy link
Contributor

Looks good!

I would maybe add a screenshot of the dropdown and option to run, I could create one for you to use that shows both Quest and Pico in the menu to make clear why it is a dropdown.

@dsnopek
Copy link
Contributor Author

dsnopek commented Jun 27, 2023

Thanks :-)

I could create one for you to use that shows both Quest and Pico in the menu to make clear why it is a dropdown

Yeah, that'd be awesome! Personally, I only have various flavors of Quest

@BastiaanOlij
Copy link
Contributor

@dsnopek you'll need to crop it and probably convert it to webp, but hopefully this helps?

Godot Android VR dropdown

@dsnopek dsnopek force-pushed the improved-meta-quest-setup branch from 203bd0e to dcc6435 Compare June 28, 2023 13:39
@dsnopek
Copy link
Contributor Author

dsnopek commented Jun 28, 2023

Thanks so much, @BastiaanOlij!

I cropped Bastiaan's screenshot and blurred the areas behind the dropdown (since they are pretty distracting), converted to webp and added to the new section about one-click deploy.

Hopefully, the blur is an OK way to do this? I could also just cut those parts out, but I worried that that could be confusing since there is stuff there and might it make it hard for folks to find the right part of the screen.

@skyace65
Copy link
Contributor

For a image like that where you want to direct people to a specific part you would add an outline instead of blurring the background. Like this:
android_one_click_deploy.zip

And if you don't mind please update your PR with that image.

@dsnopek dsnopek force-pushed the improved-meta-quest-setup branch from dcc6435 to 31d191b Compare June 29, 2023 01:20
@dsnopek
Copy link
Contributor Author

dsnopek commented Jun 29, 2023

Sure! I've updated the PR, replacing the image with yours. Thanks for making it :-)

Copy link
Contributor

@BastiaanOlij BastiaanOlij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, nice work!

@dsnopek dsnopek force-pushed the improved-meta-quest-setup branch from 31d191b to 968e8a7 Compare July 5, 2023 13:40
@skyace65 skyace65 merged commit 8855514 into godotengine:master Jul 5, 2023
@skyace65
Copy link
Contributor

skyace65 commented Jul 5, 2023

Thanks!

mhilbrunner pushed a commit that referenced this pull request Aug 1, 2023
Make the steps for deploying to Meta Quest 2 (and other Android headsets) clearer
mhilbrunner pushed a commit that referenced this pull request Aug 1, 2023
Make the steps for deploying to Meta Quest 2 (and other Android headsets) clearer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement topic:xr Related to XR documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants