GDScript: Add warning about overriding non-virtual native methods #7591
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calinou
added
enhancement
area:manual
Calinou
reviewed
Jul 1, 2023
Calinou
approved these changes
Jul 1, 2023
Member
Calinou
left a comment
Calinou
left a comment
There was a problem hiding this comment.
Should be good to merge after applying the suggestion.
dalexeev
force-pushed
the
gds-warn-override-non-virtual
branch
from
fc2f473 to
055ec90
Compare
mhilbrunner
approved these changes
Jul 18, 2023
Member
|
Thank you! Merged. I think this is well worded and a nice explanation :) |
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
mhilbrunner
added a commit
that referenced
this pull request
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See godotengine/godot#78911. I think this is an important enough aspect of the engine to be addressed, despite the fact that there is a warning in GDScript.