Remove erroneous C# example about autoloads #7604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raulsntos
added
bug
topic:dotnet
area:manual
raulsntos
approved these changes
Jul 4, 2023
Member
There was a problem hiding this comment.
Yeah, I don't remember this ever being a thing. Most likely a direct translation from the GDScript example made by a contributor that didn't use C#.
Actually, after re-reading the comment I think the example is meant to show that if the Health property is static you can access it using the type name. This has nothing to do with what the GDScript example is showing (which is that autoloads can be accessed as singletons by their name), so it could be misleading and I'm still in favor of removing it.
Contributor
|
Thanks! |
mhilbrunner
pushed a commit
that referenced
this pull request
Aug 1, 2023
Remove erroneous C# example about autoloads
mhilbrunner
pushed a commit
that referenced
this pull request
Aug 1, 2023
Remove erroneous C# example about autoloads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not exist in C# (and AFAIK, it's never been a thing).