Skip to content

Conversation

@Sauermann
Copy link
Contributor

Add note about necessary changes for SubViewportContainer input-event-propagation.

Please let me know, if I should make changes to the content or if a different format would be better (since the text is longer, one has to scroll horizontally quite a lot).

@Sauermann Sauermann changed the title Add note about behavioral changes Add note about behavioral changes to 4.1 migration guide Jul 10, 2023
@Calinou Calinou added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Jul 10, 2023
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides those 2 nitpicks this looks good to me.

@mhilbrunner mhilbrunner added this to the 4.x milestone Jul 11, 2023
@Sauermann Sauermann force-pushed the fix-migraring-svc branch 2 times, most recently from 96ee830 to 72f85f1 Compare July 11, 2023 21:13
Copy link
Member

@mhilbrunner mhilbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase, besides that looks good to go, sorry this took a bit due to some IRL stuff on my part :)

Add note about necessary changes for `SubViewportContainer`
input-event-propagation.
@Sauermann Sauermann force-pushed the fix-migraring-svc branch from 72f85f1 to 570dadb Compare July 18, 2023 21:41
@mhilbrunner mhilbrunner merged commit 84e02a9 into godotengine:master Jul 19, 2023
@mhilbrunner
Copy link
Member

Thank you! Merged.

@Sauermann Sauermann deleted the fix-migraring-svc branch July 19, 2023 17:15
@mhilbrunner
Copy link
Member

Cherry-picked to 4.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants