Skip to content

Minor fixes in getting started #8129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 9, 2023
Merged

Minor fixes in getting started #8129

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
cead73b
async return type from void to Task
FelixBurkhard Oct 2, 2023
ae09833
remove \n from label text
FelixBurkhard Oct 2, 2023
014f537
fix casing
FelixBurkhard Oct 2, 2023
2256a01
remove reminder to remove code
FelixBurkhard Oct 2, 2023
306a28d
Revert "async return type from void to Task"
FelixBurkhard Oct 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions getting_started/first_2d_game/06.heads_up_display.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ ScoreLabel
Message
~~~~~~~~~~~~

1. Add the text ``Dodge the creeps!``.
1. Add the text ``Dodge the Creeps!``.
2. Set the "Horizontal Alignment" and "Vertical Alignment" to ``Center``.
3. Set the "Autowrap Mode" to ``Word``, otherwise the label will stay on one line.
4. Under "Control - Layout/Transform" set "Size X" to ``480`` to use the entire width of the screen.
Expand Down Expand Up @@ -203,7 +203,7 @@ We also need to process what happens when the player loses. The code below will
# Wait until the MessageTimer has counted down.
await $MessageTimer.timeout

$Message.text = "Dodge the\nCreeps!"
$Message.text = "Dodge the Creeps!"
$Message.show()
# Make a one-shot timer and wait for it to finish.
await get_tree().create_timer(1.0).timeout
Expand All @@ -219,7 +219,7 @@ We also need to process what happens when the player loses. The code below will
await ToSignal(messageTimer, Timer.SignalName.Timeout);

var message = GetNode<Label>("Message");
message.Text = "Dodge the\nCreeps!";
message.Text = "Dodge the Creeps!";
message.Show();

await ToSignal(GetTree().CreateTimer(1.0), SceneTreeTimer.SignalName.Timeout);
Expand Down Expand Up @@ -310,7 +310,7 @@ signal of ``StartButton``, and add the following code to the new functions:
}

void HUD::_on_StartMessageTimer_timeout() {
_message_label->set_text("Dodge the\nCreeps");
_message_label->set_text("Dodge the Creeps!");
_message_label->show();
_start_button_timer->start();
}
Expand All @@ -337,9 +337,6 @@ window and selecting the ``new_game()`` method or type "new_game" below "Receive
in the window. Verify that the green connection icon now appears next to
``func new_game()`` in the script.

Remember to remove the call to ``new_game()`` from
``_ready()``.

In ``new_game()``, update the score display and show the "Get Ready" message:

.. tabs::
Expand Down