Reworked the pause menu example in pausing_games.rst #8165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ershn
force-pushed
the
rework_pause_menu_example
branch
from
bdca00f to
c6b272e
Compare
Calinou
added
enhancement
area:manual
Calinou
reviewed
Nov 9, 2023
Calinou
reviewed
Nov 9, 2023
raulsntos
reviewed
Nov 9, 2023
ershn
force-pushed
the
rework_pause_menu_example
branch
from
8c5b466 to
fc7a41f
Compare
Contributor
Author
|
Applied review suggestions and squashed the commits. |
raulsntos
approved these changes
Nov 10, 2023
Member
raulsntos
left a comment
raulsntos
left a comment
There was a problem hiding this comment.
The C# changes look good to me.
skyace65
approved these changes
Nov 24, 2023
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO the current example isn't very high quality. This PR tries to improve it.
menuconsistently instead of menu/popup/screen/panel