inspector_plugins.rst: add new "wide" parameter to _parse_property #8211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You will need to update the use of |
AThousandShips
added
bug
topic:gdscript
area:manual
Contributor
Author
Yeah, I had seen that but I couldn't see how to include it in a batch commit using the on-site UI. Do you want these squashed of does it not matter? |
AThousandShips
approved these changes
Oct 11, 2023
Member
AThousandShips
left a comment
AThousandShips
left a comment
There was a problem hiding this comment.
LGTM
Please squash your commits into one, see here
Contributor
Author
|
Hmm, give me another second on this one |
Godot 4.0 added a new parameter to EditorInspectorPlugin._parse_property. This was updated in the C# version of the tutorial, but not the gdscript version Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Contributor
Author
|
Okay, should be good to go |
mhilbrunner
approved these changes
Oct 13, 2023
Member
|
Merged. Thanks and congrats on your first merged contribution! |
Member
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Godot 4.0 added a new parameter to EditorInspectorPlugin._parse_property. This was updated in the C# version of the tutorial, but not the gdscript version