Skip to content

Conversation

@TimCabbage
Copy link

Instead instructed the user that the desired scaling option is available since version 4.2

…ed in v4

Instead instructed the user that the desired scaling option is available since version 4.2
@Piralein Piralein added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 13, 2023
@skyace65 skyace65 added this to the 4.2 milestone Oct 15, 2023
Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change but a few things should be adjusted. I do not think saying that a subviewport was used for this in older Godot versions is necessary. Anyone looking up info for an older Godot version should be using the older version of the docs.

Additionally I don't think this info should be in a note since it's as necessary as what's in the bullet points above the note. I'd make it a bullet point under the one for "set the stretch aspect to keep..." Something like "Set the scale mode to integer"

When editing a doc PR please keep everything to one commit, if you don't know how to do that we have a guide here.

@mhilbrunner
Copy link
Member

We just merged a PR that supersedes this one: #8298, so I'm going to close this one. Thanks for pointing this out and taking the time to contribute :)

@mhilbrunner mhilbrunner removed this from the 4.2 milestone Oct 22, 2023
@mhilbrunner mhilbrunner added archived and removed enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Oct 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants