Correct the description of "tree order" #8294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correct the description of "tree order". The discussion conflated _ready()'s unusual traversal order (post-order traversal) with the usual "tree order" (preorder traversal) for most operations. It seemed to imply that _ready and most other notifications were received in identical orders.
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com>
michaelgundlach
changed the title
michaelgundlach
changed the title
Calinou
added
bug
area:manual
Calinou
reviewed
Nov 9, 2023
Calinou
approved these changes
Nov 9, 2023
YuriSizov
approved these changes
Nov 9, 2023
mhilbrunner
approved these changes
Nov 9, 2023
Member
|
Merged. Thanks and congrats on your first merged contribution! |
mhilbrunner
pushed a commit
to mhilbrunner/godot-docs
that referenced
this pull request
Nov 11, 2023
* Update scene_tree.rst Correct the description of "tree order". The discussion conflated _ready()'s unusual traversal order (post-order traversal) with the usual "tree order" (preorder traversal) for most operations. It seemed to imply that _ready and most other notifications were received in identical orders. --------- Co-authored-by: A Thousand Ships <96648715+AThousandShips@users.noreply.github.com> Co-authored-by: Hugo Locurcio <hugo.locurcio@hugo.pro>
Member
|
Cherry-picked to 4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct the description of "tree order".
The discussion conflated _ready()'s unusual traversal order (post-order traversal) with the usual "tree order" (preorder traversal) for most operations. It seemed to imply that _ready and most other notifications were received in identical orders.