3d game tutorial bug on squashing #8333
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| // We check that we are hitting it from above. | ||
| if (Vector3.Up.Dot(collision.GetNormal()) > 0.1f) | ||
| if (mob.IsQueuedForDeletion() && Vector3.Up.Dot(collision.GetNormal()) > 0.1f) |
Member
There was a problem hiding this comment.
Suggested change
| if (mob.IsQueuedForDeletion() && Vector3.Up.Dot(collision.GetNormal()) > 0.1f) | |
| if (!mob.IsQueuedForDeletion() && Vector3.Up.Dot(collision.GetNormal()) > 0.1f) |
You've got it backwards here
| { | ||
| // We check that we are hitting it from above. | ||
| if (Vector3.Up.Dot(collision.GetNormal()) > 0.1f) | ||
| if (mob.IsQueuedForDeletion() && Vector3.Up.Dot(collision.GetNormal()) > 0.1f) |
Member
There was a problem hiding this comment.
Suggested change
| if (mob.IsQueuedForDeletion() && Vector3.Up.Dot(collision.GetNormal()) > 0.1f) | |
| if (!mob.IsQueuedForDeletion() && Vector3.Up.Dot(collision.GetNormal()) > 0.1f) |
Calinou
added
bug
area:getting started
Member
|
Thanks for the contribution nonetheless! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collision detection with the enemies in the "Your first 3D Game" tutorial is written in way that makes it possible for the squash event to be emitted multiple times. This happened to me regularly and messed up the score tracking afterwards because it incremented the score by more than one. I am not sure if this is the best to do this or to handle collisions in Godot 4 in general as I am still rather new but I thought I'd submit it as an issue here.