-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
fix : use the earlier name of the player input script #8418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix : use the earlier name of the player input script #8418
Conversation
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A more comprehensive fix needs to be done for this issue. the C# name doesn't match the GDScript name, and the GDScript name doesn't match the image for creating the script, and instructions should be given to give it a specific name. Also having people just add a underscore to make the script name not the node name is probably bad practice.
Would you like to update this PR to do those changes? If not I can make a separate PR fixing them.
|
Oh my. You're right. I'll see what I can do. But I would like some clarifications.
|
|
The script name should be snake_case: I believe the c# name change is correct, as it is already named like this in the previous guide setting up the script. |
|
@a2937 The template needs to be set to Adding the yellow outline for the "Template" input would be great. (it isn't necessary for the path) |
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is good now that Piralein updated the image in #8558
|
Thanks! |
|
Cherry-picked to 4.2. |
Renames the class
Spriteback toMySprite2Din the player input lesson plan.Closes #8417