Skip to content

Conversation

@Cerno-b
Copy link
Contributor

@Cerno-b Cerno-b commented Nov 11, 2023

Fixes #8399

Reorganise sections in "about", as discussed in #8399

This also moves "troubleshooting" to "manual".

@YuriSizov
Copy link
Contributor

Don't forget the redirects file! :)

@Cerno-b
Copy link
Contributor Author

Cerno-b commented Nov 11, 2023

Don't forget the redirects file! :)

I suppose I need to generate it via create_redirects.py, but I have trouble getting the script to run. It requires an API key from Read the Docs. I managed to get one, but apparently that one does not give me the permissions I need for the script to work. Am I missing something?

@Cerno-b
Copy link
Contributor Author

Cerno-b commented Nov 11, 2023

Ok, I ran the other script, convert_git_renames_to_csv.py and it gave me a csv file that looked like the redirects.csv, so I copied the contents from the generated file to the redirects.csv.

Could you check if this is plausible? I'm doing this for the first time and don't know if I'm missing anything else.

@AThousandShips
Copy link
Member

Your commit seems not to be linked to your GitHub account. See: Why are my commits linked to the wrong user? for more info.

@Cerno-b
Copy link
Contributor Author

Cerno-b commented Nov 11, 2023

@AThousandShips Sorry, I recently changed my git client's e-mail address and did not update it in Github. I did that now, but I don't know if this resolved the issue since I didn't see it in the first place. Can you see whether it's fine now? Sorry for the inconvenience.

@AThousandShips
Copy link
Member

It is, previously the icon of the commits were blank

Once this has been decided on, or now if you feel up for it, please squash your commits into one, see here

If making further changes please use git commit --amend to not add unnecessary commits to the history

@Cerno-b Cerno-b force-pushed the reorganise-about-headers branch from 8416ec8 to bc2ff75 Compare November 11, 2023 16:16
@Cerno-b
Copy link
Contributor Author

Cerno-b commented Nov 11, 2023

@AThousandShips Done.

@AThousandShips AThousandShips added enhancement content:organization Issues and PRs related to reorganizing the content labels Nov 11, 2023
@YuriSizov
Copy link
Contributor

Could you check if this is plausible? I'm doing this for the first time and don't know if I'm missing anything else.

It's all good now. You aren't supposed to run the script that updates the redirects, only to edit the CSV file.

@mhilbrunner mhilbrunner merged commit 643001f into godotengine:master Nov 25, 2023
@mhilbrunner
Copy link
Member

Thanks for contributing! Merged.

@YuriSizov
Copy link
Contributor

YuriSizov commented Dec 20, 2023

@mhilbrunner Did you update the redirects from this PR? See godotengine/godot-website#773.

Edit: I guess I should've added this label :P

@YuriSizov YuriSizov added the content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend label Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content:organization Issues and PRs related to reorganizing the content content:redirect Issues and PRs involving moving content and adding a redirect rule on the backend enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-order sections of the About category

5 participants