Add enum value iteration example

[TheYellowArchitect]

Solves a misunderstanding of iterating enums

• Bugsquad edit, closes: GDScript - Iterating enum integers casts them to string #8598

[timothyqiu]

I think you can put your example code snippet directly inside the codeblock above. It's showing how one can use named enum like a dictionary, iterating is one of the operations.

[TheYellowArchitect]

I applied all suggested changes (github having built-in batch for suggestions is quite the feature addition)

If you want me to lessen it down (because right now there may be redundance), give the suggestion and I will apply it

[AThousandShips]

Can apply it as a more global suggestion soon, but you should also squash your commits before this can be merged, see here

[AThousandShips]

Just need a squash and it looks good

[TheYellowArchitect]

First time I squash succesfully. Also changed State to States
Do doublecheck to confirm I didn't do any mistake via squash

[AThousandShips]

You need to rebase your branch, when squashing you accidentally rewound your branch because you hadn't updated your local fork, please do git rebase -i upstream/master

Also I'd say the naming doesn't matter, leave it as State to reduce the unnecessary changes

[TheYellowArchitect]

I apologize for my newbieness. I understand that if someone else did this 2 minute pull request it would be done, so I apologize in advance. At least from this I hope I learn how to rebase for future commits.

=====

git rebase -i upstream/master
outputs
fatal: invalid upstream 'upstream/master' even after I did the below 2 git fetch commands

git fetch https://[githubPersonalTokenKey]@github.com/TheYellowArchitect/godot-docs.git master
outputs

From https://github.com/TheYellowArchitect/godot-docs
 * branch                       master          -> FETCH_HEAD

git fetch https://github.com/godotengine/godot-docs master
outputs

From https://github.com/godotengine/godot-docs
 * branch                       master          -> FETCH_HEAD

^With either of the above, if I git rebase -i [commitId] and select only this one commit
pick 27340cd89 Added enum iteration example
it outputs
Succesfully rebased and updated refs/heads/patch-11

And then I input
git push --force https://[githubkey]@github.com/TheYellowArchitect/godot-docs.git
it outputs
Everything up-to-date

[AThousandShips]

And if you do git rebase -i master?

If you can't figure it out I can fix your branch for you

[TheYellowArchitect]

And if you do git rebase -i master?

I think it worked out. Do confirm I didn't mess up the history 😅

[AThousandShips]

Use git commit --amend when fixing, and then git push --force

[TheYellowArchitect]

Should I restore the whitespace here? If yes, should I place it between the below print statements so they aren't a united codeblock?

[AThousandShips]

Put it after the last line of code, keep two lines before "Functions", easier to read

[TheYellowArchitect]

Above commit should be good. That said, I apologize for taking so much of your precious time on such a simple/frequent task 😓

[AThousandShips]

Thank you for bearing with the review 🙂 looks great!

[mhilbrunner]

Indeed, thanks for being accomodating and doing all the work (and for taking your time to contribute in the first place!). And don't worry, we all have to learn some time, no one knows everything. Always feel welcome to ask for help in the comments or in the #documentation channel in contributors chat. Thank you!

And thanks for reviewing ATS :)

[timothyqiu]

Wait...

This is not true. State is a Dictionary so it should print { "STATE_IDLE": 0, "STATE_JUMP": 5, "STATE_SHOOT": 6 }. Or it should be print(State.keys()) instead.

[mhilbrunner]

Cherry-picked to 4.2.