Slight polish at enum example

[TheYellowArchitect]

@timothyqiu detected a wrong comment output in #8599 (comment)

I also noticed STATE_SHOOT of the enum is 6 at const but not at enum, also fixed. Made it 7 instead of 5, so it's obvious that the user can step and it's not in i++ order

[AThousandShips]

I also noticed STATE_SHOOT of the enum is 6 at const but not at enum, also fixed.

Tested and it does print 6 in code, please confirm, as I ran it and it worked correctly, the current code is good as it does show the next value is incremented from the last one, so you can do groupings, like { FOO = 10, BAR (= 11), BOO = 20, BAZ (= 21) }

[AThousandShips]

See above, this works as advertised in my testing, please test yourself, and the way it works here helps with indicating how it continues counting from the last value, but the correction in print(State) is good

This is the output when running the code in the documentation currently:

5
["STATE_IDLE", "STATE_JUMP", "STATE_SHOOT"]
{ "STATE_IDLE": 0, "STATE_JUMP": 5, "STATE_SHOOT": 6 }
[0, 5, 6]

[dalexeev]

Named enums can be used as type hints, unlike constant dictionaries, so they are not the same thing.

[timothyqiu]

Then the wording above should be improved too, as it says it's exactly a dictionary.

godot-docs/tutorials/scripting/gdscript/gdscript_basics.rst

Lines 1220 to 1222 in ca93dda

	If you pass a name to the enum, it will put all the keys inside a constant
	:ref:`Dictionary <class_Dictionary>` of that name. This means all constant methods of
	a dictionary can also be used with a named enum.

[dalexeev]

The order is reversed, print(State) prints a dictionary, and print(State.keys()) prints an array of keys (here the values).

[AThousandShips]

That's print(State.values()), it's above the line that has the command

[AThousandShips]

It's:

print(State.keys()) # prints '["STATE_IDLE", "STATE_JUMP", "STATE_SHOOT"]'
print(State)  # prints '{ "STATE_IDLE": 0, "STATE_JUMP": 5, "STATE_SHOOT": 7 }'
print(State.values()) # prints '[0, 5, 7]'

Reformating as this would make it clearer

[TheYellowArchitect]

I would like to add spaces between so it's more clear, but it seems every little change I add ruins something else, so I will commit only the suggestions 👍

[dalexeev]

Suggested change

	# Use constant dictionary functions
	# Use dictionary methods:

This refers to methods with the const qualifier, but they are not currently evaluated as constant expressions, even when called on constant dictionaries or named enums.

[TheYellowArchitect]

I apologize for my oversight. I did git commit --amend, implementing the recommended suggestions.

[mhilbrunner]

Thank you! Merged.

[mhilbrunner]

Cherry-picked to 4.2.