Removed reference to 'DEPTH' in CanvasItem shaders #8616
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
topic:rendering
area:manual
mhilbrunner
approved these changes
Dec 13, 2023
Member
|
Merged. Thanks and congrats on your first merged contribution! @clayjohn Does this apply to 4.0/4.1 too? If so, please apply the cherry-pick labels :) |
Member
|
@mhilbrunner Done! |
mhilbrunner
pushed a commit
that referenced
this pull request
Jan 25, 2024
* Remove 'DEPTH' constant from CanvasItem shaders * Re-added Origin mention
Member
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed references to a 'DEPTH' constant that doesn't exist and unused 'z' coordinates from the CanvasItem shader page, as brought up by issue #8541.