Fix UV mapping in ArrayMesh tutorial #8640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I think you might have found an engine bug that was patched in 4.2.1. I booted up your example project in 4.2.1 and this is what I'm seeing:
The only thing that looks off is on the back of the spheres and it appears for the old and new code:
|
Contributor
Author
|
Thanks for the feedback! What you see in the viewport for both spheres is generated by the existing code, so it doesn't reflect the difference. You need to run the program in order to see the difference between the existing code and what this PR proposes. |
Contributor
|
Apologies, the new code definitely looks better. |
skyace65
approved these changes
Dec 18, 2023
mhilbrunner
added
bug
topic:rendering
area:manual
mhilbrunner
approved these changes
Dec 18, 2023
Member
|
Merged. Thanks and congrats on your first merged contribution! |
mhilbrunner
added a commit
that referenced
this pull request
Jan 25, 2024
Fix UV mapping in ArrayMesh tutorial
Member
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses an issue with UV mapping in the sample code provided in the Godot Documentation for creating a procedural mesh. The original code resulted in a UV mapping discrepancy, which has been corrected in this update.
Problem: The last radial segment didn't have correct UV mapping.
Solution: Created dummy vertices for the last segment of the sphere, and used those to generate correct UV mapping.
To test it yourself, you can download this project:
MeshGenerationTest.zip