Skip to content

Fix UV mapping in ArrayMesh tutorial #8640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Fix UV mapping in ArrayMesh tutorial #8640

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 2 additions & 22 deletions tutorials/3d/procedural_geometry/arraymesh.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ that you find online.
var y = cos(PI * v)

# Loop over segments in ring.
for j in range(radial_segments):
for j in range(radial_segments + 1):
var u = float(j) / radial_segments
var x = sin(u * PI * 2.0)
var z = cos(u * PI * 2.0)
Expand All @@ -285,15 +285,6 @@ that you find online.
indices.append(thisrow + j)
indices.append(thisrow + j - 1)

if i > 0:
indices.append(prevrow + radial_segments - 1)
indices.append(prevrow)
indices.append(thisrow + radial_segments - 1)

indices.append(prevrow)
indices.append(prevrow + radial_segments)
indices.append(thisrow + radial_segments - 1)

prevrow = thisrow
thisrow = point

Expand Down Expand Up @@ -324,7 +315,7 @@ that you find online.
var y = Mathf.Cos(Mathf.Pi * v);

// Loop over segments in ring.
for (var j = 0; j < _radialSegments; j++)
for (var j = 0; j < _radialSegments + 1; j++)
{
var u = ((float)j) / _radialSegments;
var x = Mathf.Sin(u * Mathf.Pi * 2);
Expand All @@ -348,17 +339,6 @@ that you find online.
}
}

if (i > 0)
{
indices.Add(prevRow + _radialSegments - 1);
indices.Add(prevRow);
indices.Add(thisRow + _radialSegments - 1);

indices.Add(prevRow);
indices.Add(prevRow + _radialSegments);
indices.Add(thisRow + _radialSegments - 1);
}

prevRow = thisRow;
thisRow = point;
}
Expand Down