Skip to content

Fix Windows build command highlighting. #8664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 22, 2023
Merged

Fix Windows build command highlighting. #8664

merged 1 commit into from
Dec 22, 2023

Conversation

@bruvzg
Copy link
Member

@bruvzg bruvzg commented Dec 21, 2023

Fixes highlighting:

Before After
Screenshot 2023-12-21 at 21 34 20 Screenshot 2023-12-21 at 21 34 31

@bruvzg bruvzg added bug area:engine details Issues and PRs related to the Engine Details section of the documentation labels Dec 21, 2023
@bruvzg bruvzg mentioned this pull request Dec 21, 2023
Merged
AThousandShips
AThousandShips approved these changes Dec 21, 2023
View reviewed changes
growingbrain
growingbrain approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@growingbrain growingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks much better.

@mhilbrunner mhilbrunner merged commit c52a73a into godotengine:master Dec 22, 2023
@mhilbrunner
Copy link
Member

mhilbrunner commented Dec 22, 2023

Thank you! Merged.

@YuriSizov
Copy link
Contributor

YuriSizov commented Dec 22, 2023 •
edited
Loading

Oh, didn't know about doscon. Although we lose highlighting for the scons arguments, and overall the prefix part is not really useful (I don't know why there is a tradition to show it, or like $ for Linux shells), and can probably be simply removed from the command snippet.

mhilbrunner added a commit that referenced this pull request May 7, 2024
@mhilbrunner
Merge pull request #8664 from bruvzg/win_cmds
da7e547 
Fix Windows build command highlighting.

(cherry picked from commit c52a73a)

# Conflicts:
#	contributing/development/compiling/compiling_for_windows.rst
@mhilbrunner
Copy link
Member

mhilbrunner commented May 7, 2024

Cherry-picked to 4.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mhilbrunner mhilbrunner mhilbrunner approved these changes

@AThousandShips AThousandShips AThousandShips approved these changes

+1 more reviewer

@growingbrain growingbrain growingbrain approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:engine details Issues and PRs related to the Engine Details section of the documentation bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@bruvzg @mhilbrunner @YuriSizov @AThousandShips @growingbrain