Update spatial_shader.rst to mention godot use the same VIEW vector for both perspective and orthogonal cameras. #8708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or both perspective and orthogonal cameras.
Member
|
Edit, nevermind, there was no PR, the discussion was only in the issue you linked |
clayjohn
approved these changes
Jan 3, 2024
AThousandShips
added
enhancement
topic:rendering
area:manual
mhilbrunner
approved these changes
Jan 3, 2024
Member
|
Thank you! Merged. |
mhilbrunner
added a commit
that referenced
this pull request
Jan 25, 2024
Update spatial_shader.rst to mention godot use the same VIEW vector for both perspective and orthogonal cameras.
Member
|
Cherry-picked to 4.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in godotengine/godot#68881 , we can update the doc for now.
I will take a look whether it's convient to change the VIEW vector to vec3(0, 0, 1) for orthogonal cameras later.