Skip to content

Conversation

@adamscott
Copy link
Member

This moves the Giscus insertion logic inside custom.js.

Technically, it could have worked if I would have done this instead:

{% if (not meta or meta.get('allow_comments') != 'False') and godot_show_article_comments and pagename != 'search' %}

... but it's easier to maintain my way, as we can add easily new pages to ban.

@mhilbrunner
Copy link
Member

cc @Calinou

@Calinou Calinou added bug content:website Issues related to adding website features and fixing bugs, whether on the front or back-end cherrypick:4.1 cherrypick:4.2 labels Jan 22, 2024
Copy link
Member

@Calinou Calinou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, it works as expected.

@Calinou Calinou merged commit bedd304 into godotengine:master Jan 23, 2024
@mhilbrunner mhilbrunner removed the request for review from YuriSizov January 24, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug cherrypick:4.1 cherrypick:4.2 content:website Issues related to adding website features and fixing bugs, whether on the front or back-end

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants