Several improvements to "First 3D Game" tutorial #8955
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyace65
added
bug
area:getting started
This fixes the "Animation > Copy" issue mentioned in godotengine#6744 (see Step 09, around Line 264) The same issue as above was referenced in godotengine/godot#60848 and the fix was to use the solution by @riidom Also, a reference to a button icon has been changed from "A+" to "A>" per feedback on PR 8460
skyace65
force-pushed
the
First3DGamePRFix
branch
from
30fef57 to
c1c33e7
Compare
Contributor
Author
|
@shane-smith sorry about the issue with your original PR, it needed to be rebased because of a file conflict. But congrats on your first merged PR! |
This was referenced Feb 14, 2024
Contributor
|
Whoa yeah I can see the rebase mess in the history on the other issue 😅 Thanks @skyace65 for fixing and pushing it over the line. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Salvage of #8460 which I broke while trying to rebase.