-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Several improvements to "First 3D Game" tutorial #8460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Calinou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be good to merge after addressing suggestions.
|
Thanks for the feedback! I'll work on this and get back to you. |
|
I will squash this into a single commit (and rebase on the current master branch) and then it's ready for re-review. |
9af0531 to
62cbcf1
Compare
|
It is ready for you now @Calinou - let me know if you have any further feedback 🙂 |
skyace65
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, I'd prefer to leave the "article outdated" warnings for now. There's still stuff on other pages that needs to be updated or fixed. but I'd be okay with merging this as is if others think it's fine.
I'll work on a PR to address the remaining issues once this one is merged.
|
I'll restore the warnings 👍 |
Fix Windows build command highlighting.
Update custom drawing in 2d tutorial to Godot4
Update D3D12 build instructions.
Update textureQueryLevels to mention it returns 1 when the texture is unassigned
Update OS to Time on pages containing OS.get_ticks_usec()
* Fixed typo in pr_workflow.rst
[Minor] Fix typo in `importing_images.rst` ("Rougness" should be "Roughness")
classref: Sync with current master branch (13a0d6e)
Update link to Rust GDExtension bindings
singletons_autoload.rst: add C# example similar to "Global Variable"
…uirements Update the Emscripten minimum requirements to 3.1.39
Add info on finding script templates folder
Build offline version of stable branch
Update gui_using_fonts.rst
GDScript: Document `is not` operator
Remove duplicate information in autoload page
Update C# API in the code example of "Custom GUI controls"
Remove Godot 3 reference from profiler page
Clarify which track is being talked about
Clarify which scene to run in step by step
classref: Sync with current master branch (4e990cd)
Update compiling_for_linuxbsd.rst Added a description that compiling for RISC-V devices
This fixes the "Animation > Copy" issue mentioned in #6744 (see Step 09, around Line 264) The same issue as above was referenced in godotengine/godot#60848 and the fix was to use the solution by @riidom Also, a reference to a button icon has been changed from "A+" to "A>" per feedback on PR 8460
…godot-docs into patch-first-3d-game
|
Salvaged by #8955 |
The tutorial has been marked as compatible with the latest version - I just ran through it and verified that each step can be completed in Godot 4.1.3 stable.
A few fixes have been made, and other sections clarified to help first-time users of Godot.
I have made no changes to images - only text.
Note that this also fixes the "Animation > Copy" issue mentioned in #6744