Merge pull request #74777 from lawnjelly/textedit_lineinregion

akien-mga · web-flow · commit 16df3416fad9 · 2023-03-12T16:12:36.000+01:00
[3.x] Fix TextEdit color_region_cache bug
diff --git a/scene/gui/text_edit.cpp b/scene/gui/text_edit.cpp
@@ -5488,7 +5488,7 @@ int TextEdit::_is_line_in_region(int p_line) {
 	// If not find the closest line we have.
 	int previous_line = p_line - 1;
 	for (; previous_line > -1; previous_line--) {
-		if (color_region_cache.has(p_line)) {
+		if (color_region_cache.has(previous_line)) {
 			break;
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -5488,7 +5488,7 @@ int TextEdit::_is_line_in_region(int p_line) {`
`5488`	`5488`	`// If not find the closest line we have.`
`5489`	`5489`	`int previous_line = p_line - 1;`
`5490`	`5490`	`for (; previous_line > -1; previous_line--) {`
`5491`		`- if (color_region_cache.has(p_line)) {`
	`5491`	`+ if (color_region_cache.has(previous_line)) {`
`5492`	`5492`	`break;`
`5493`	`5493`	`}`
`5494`	`5494`	`}`