Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button shorter after update of FreeType from 2.9.1 to 2.10.0 #28335

Open
ForLoveOfCats opened this issue Apr 23, 2019 · 13 comments

Comments

Projects
None yet
3 participants
@ForLoveOfCats
Copy link
Contributor

commented Apr 23, 2019

Godot versions:
Godot Mono 3.1.0 Beta 11 and Godot Mono 3.1.1 RC1

OS/device including version:
Manjaro Linux x64 w/Intel Sandybridge Mobile iGPU running Mesa 19.0.2-1

Issue description:
Upon upgrading from Godot Mono 3.1.0 Beta 11 to Godot Mono 3.1.1 RC1 my game's buttons went from this:
image
to this:
image

Switching between GLES2 and GLES3 does not effect either version. For the sake of completeness I will mention that these are both Mono builds but that should (hopefully) not be related to this issue.

Here is a reproduction project: ButtonSizeBug.zip
Godot Mono 3.1.0 Beta 11:
image
Godot Mono 3.1.1 RC1:
image

@ForLoveOfCats

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

I possible I would like to attempt to fix this myself as I am trying to become more familiar with Godot's codebase and contribute more.

Edit: The hardware I am stuck with ATM is not up to compiling Godot quite a few times in order to find the root commit

@hpvb

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Can you please check the difference between 3.1.0-stable and 3.1.1-rc1?

@ForLoveOfCats

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Issue is not present in Godot Mono 3.1.0 Stable
image

@hpvb

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

OK, so this is a difference between 3.1.0-stable and 3.1.1-rc1?

@ForLoveOfCats

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

The issue is not present in 3.1.0 Stable but is present in 3.1.1 RC1

@hpvb hpvb added this to the 3.1 milestone Apr 23, 2019

@hpvb hpvb added the regression label Apr 23, 2019

@hpvb hpvb self-assigned this Apr 23, 2019

@hpvb

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

If you want to look at this yourself use git bisect between 3.1.0-stable and the tip of the 3.1 branch. You should find it with about 7 compilations currently. Then we know what backport caused it and we can see if there's a fix for it already or revert it in 3.1 before release of 3.1.1-stable.

@ForLoveOfCats

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

Oof I'm stuck on this under powered laptop for the time being... While I would like to try to fix this myself that just isn't practical. Editing my original comment about doing this myself.

@akien-mga akien-mga changed the title Button shorter after upgrading 3.1.0 Beta 11 -> 3.1.1 RC1 Button shorter after upgrading 3.1-stable -> 3.1.1 RC1 Apr 23, 2019

@akien-mga

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

I don't see any difference with the attached project between 3.1-stable and current 3.1 HEAD (476e179) (non Mono build).

Edit: I do get the issue in 3.1.1-rc1 though. Testing a release_debug build locally to see if it's related.

@akien-mga

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

Tested so far, all non-Mono on X11 64-bit:

  • 3.1-stable (release_debug, LTO): OK
  • 3.1.1-rc1 aka 39f1a11 (release_debug, LTO): bug
  • 39f1a11 local build (debug, no LTO): OK
  • 4764e17 local build (debug, no LTO): OK
  • 4764e17 local build (release_debug, no LTO): OK
  • 4764e17 local build (release_debug, LTO): OK

So not sure what's left to test, but something is wrong only in the official 3.1.1-rc1 build.

@hpvb

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

This is very puzzling as no changes were made to the build containers at all.

@akien-mga

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

This is probably due to the freetype version change.

@hpvb

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

I'll test with the freetype version reverted.

akien-mga added a commit that referenced this issue Apr 25, 2019

Revert "Update freetype to 2.10.0"
This reverts commit 9e2cf9e.

It caused this regression: 28335.
Fixes #28335.
@akien-mga

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

I can confirm that the update of the builtin freetype version is the problem. I've reverted it in the 3.1 branch, so the bug is fixed there, but we still need to figure out the issue for the master branch (especially as it means that linking against system freetype 2.10.0+ may trigger the issue again for 3.1.x or even 3.0.x).

@akien-mga akien-mga modified the milestones: 3.1, 3.2 Apr 25, 2019

@akien-mga akien-mga changed the title Button shorter after upgrading 3.1-stable -> 3.1.1 RC1 Button shorter after update of FreeType from 2.9.1 to 2.10.0 Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.