Command+B for Play the project shortcut sometimes takes two presses to activate

[Sakari369]

Godot version:
3.2.rc2.official

OS/device including version:
Macbook Pro 2014, macOS 10.14.16

Issue description:
Since updating to 3.2rc1, sometimes, but not always, usually when initially loading a project and trying to play it with Command+B keyboard shortcut, it takes two presses of the shortcut to actually start the project.

I did not see this happen with the latest 3.1 version. Reporting this for now,maybe will look into it more by compiling the engine and seeing what happens, but unfortunately don't have more info about this.

Steps to reproduce:
I don't know how to 100% reproduce this, as sometimes the Command+B works perfectly, but usually when initially I have loaded a project, and try to play it with Command+B, it needs two presses to start.

This might have something to do with the mouse focus, although I'm not sure, sometimes moving the mouse to a different location on the UI seems to help, this might be totally bogus though, I don't know.

Minimal reproduction project:

This seems to happen on any project I've already made.

[Sakari369]

Here you can see the behaviour. Observe the keyboard shortcuts being displayed on the bottom right of the animated gif.

[hiulit]

• Godot Engine v3.2.stable.official
• MacBook Pro (Retina, 15-inch, Mid 2015)
• OpenGL ES 3.0 Renderer: Intel Iris Pro OpenGL Engine

It's happening to me too.

I can't seem to find a pattern. Sometimes it happens and sometimes it doesn't.

[Calinou]

Can anyone reproduce this on Windows or Linux (with the F5 shortcut instead)?

@inDigiNeous @hiulit Can you reproduce this if you change the Editor > Play shortcut to something like F5 in the Editor Settings? If you can't bind F5, bind any other shortcut that doesn't require a modifier to be used.

[hiulit]

@Calinou I just changed it to Enter, and it works every time I press it.
I also tried F5 (which on a Mac laptop it's actually fn + F5) and it also works every time.

[Calinou]

To macOS users: can you reproduce this on any earlier 3.2 build (from alpha0 to rc4)? You can download them here.

[akien-mga]

Might be worth checking if there's anything else bound to Cmd+B in the editor shortcuts that might take precedence.

CC @bruvzg

[hiulit]

@Calinou @akien-mga I found out that there are 3 shortcuts that use cmd + B.

[akien-mga]

Can you test disable the script text editor one and/or the tile map editor one to see if either of those is conflicting?

It could also explain the seemingly "random" behavior of the issue, maybe it's only not working the first time when you have the script editor or a tilemap in focus.

[Sakari369]

@akien-mga Can confirm that changing the shortcut to F5 at least seems to fix this.

Disabling the other shortcuts with Command+B makes the play command execute in more cases, but after about 1 hour of use I still have to press Command+B twice sometimes when returning focus to the Godot window. Will test more with the F5 for example to see if this works always.

[Sakari369]

To macOS users: can you reproduce this on any earlier 3.2 build (from alpha0 to rc4)? You can download them here.

I have seen this on all 3.2 RC1, RC2 and RC4 a least (skipped RC3 i think), and now on 3.2 master also. Didn't see this on 3.1.1 or 3.1.2.

[hiulit]

Can you test disable the script text editor one and/or the tile map editor one to see if either of those is conflicting?

@akien-mga I've tried disabling the script editor shortcut and it seems to work better, but not a 100%.

Also, I'm adding Play Scene Cmd + R into the mix.

It behaves as bad as Play Cmd + B.

And I didn't see this behaviour in 3.1.x either.

[KoBeWi]

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

[Sakari369]

Can anyone still reproduce this bug in Godot 3.2.3 or any later release?

Hey! Still can see in 3.2.4 beta4 ! Feels like sometimes I have to click the main view to make it work. Not sure though, after I moved to using F5 i have not seen it happen, so it has something to do probably with Cmd+B being bound to multiple things or having to handle a key combination differently than a single key ? Just guessing.

[EricEzaM]

Might be fixed in master, needs testing.

[coppolaemilio]

I was having issues running the game by pressing command + B on my Mac (M1, Ventura 13.2.1).
To fix it I had to remove a shortcut that was already using the same command as noted on a comment above.

Godot version: 4.0.1.stable

[fdstevex]

Still happening in 4.1.3. Cmd-B is also bound to Bookmark by default, and when the cursor is sitting in an editor, that seems to take precedence. Removed that binding and Cmd-B to Run Project works reliably.

[coppolaemilio]

I guess the solution would be to change the shortcut for bookmark to Cmd-shift-B in mac?

[fdstevex]

I went looking for where this is defined and it seems like the current default is Option-B.

So maybe this issue is only hitting people who have a keymap that was created before this change?

https://github.com/godotengine/godot/blob/4c5a1484527ec5f8e320a24d0ee4c4fde0514776/editor/gui/editor_run_bar.cpp#L381C2-L381C2

[bruvzg]

I went looking for where this is defined and it seems like the current default is Option-B.

KeyModifierMask::META is Command not Option, Option+B can't be used since it's used to input some special characters (like ∫).

[fdstevex]

Ok - so yeah the fix is as you said, change the shortcut for Go to Next Bookmark to Cmd-Shift-B.

Actually - Cmd-Shift-B is already Toggle Bookmark. Cmd-Shift-Option-B?

[bruvzg]

yeah the fix is as you said, change the shortcut for Go to Next Bookmark to Cmd-Shift-B.

It's already used as well as most others options (and already have other conflicts as well):

godot/editor/plugins/script_text_editor.cpp

Lines 2484 to 2486 in 4c5a148

	ED_SHORTCUT("script_text_editor/toggle_bookmark", TTR("Toggle Bookmark"), KeyModifierMask::CMD_OR_CTRL | KeyModifierMask::ALT | Key::B);
	ED_SHORTCUT("script_text_editor/goto_next_bookmark", TTR("Go to Next Bookmark"), KeyModifierMask::CMD_OR_CTRL | Key::B);
	ED_SHORTCUT("script_text_editor/goto_previous_bookmark", TTR("Go to Previous Bookmark"), KeyModifierMask::CMD_OR_CTRL | KeyModifierMask::SHIFT | Key::B);

godot/editor/plugins/script_text_editor.cpp

Line 2495 in 4c5a148

ED_SHORTCUT_OVERRIDE("script_text_editor/toggle_breakpoint", "macos", KeyModifierMask::META | KeyModifierMask::SHIFT | Key::B);

godot/editor/plugins/canvas_item_editor_plugin.cpp

Line 5352 in 4c5a148

p->add_shortcut(ED_SHORTCUT("canvas_item_editor/skeleton_make_bones", TTR("Make Bone2D Node(s) from Node(s)"), KeyModifierMask::CMD_OR_CTRL | KeyModifierMask::SHIFT | Key::B), SKELETON_MAKE_BONES);

It's quire hard to find free combinations (at least without using 3+ modifiers) and avoid conflicts with input and system shortcuts. So it's definitely not the only one with this issue.

[fdstevex]

Yeah no kidding. "Run Project" is probably one of the most important shortcuts and the current behaviour where it works sometimes is maddening.

[coppolaemilio]

I would be in favor of removing the bookmark shortcut for mac users just to get the running one by default